This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix the processing of Meta-key commands in TUI
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 28 Aug 2014 17:13:40 +0100
- Subject: Re: [PATCH] Fix the processing of Meta-key commands in TUI
- Authentication-results: sourceware.org; auth=none
- References: <1408740286-29326-1-git-send-email-patrick at parcs dot ath dot cx> <53FF12FF dot 3020003 at redhat dot com> <CA+C-WL--4dJFN6_KN_PUZAqf43vJdRMPkx0ixpqRj_hqVM2WGA at mail dot gmail dot com>
On 08/28/2014 03:18 PM, Patrick Palka wrote:
> On Thu, Aug 28, 2014 at 7:31 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 08/22/2014 09:44 PM, Patrick Palka wrote:
>>> +
>>> + if (async_command_editing_p && key_is_start_sequence (ch))
>>
>> I think the key_is_start_sequence check means that we'll
>> fail to compensate in case the sequence if longer than
>> 2 bytes? That is, we'll compensate for the second char,
>> but fail to compensate for the third, because by then,
>> ch will not be a start sequence key.
>
> Yes I think so. I only took into account common 2-byte sequences such
> as Alt_F. I suppose that the check could be removed to account for
> 3+-byte key sequences too, but I haven't thought out the consequences
> of such change. And I'm not sure that readline uses any of such
> sequences.
It's fine with me to leave this as is, if we add a comment
mentioning this issue.
Thanks,
Pedro Alves