This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 4/6] Implement support for recording extension register ld/st insn
- From: Pedro Alves <palves at redhat dot com>
- To: Omair Javaid <omair dot javaid at linaro dot org>, Will Newton <will dot newton at linaro dot org>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Wed, 27 Aug 2014 11:17:50 +0100
- Subject: Re: [PATCH v3 4/6] Implement support for recording extension register ld/st insn
- Authentication-results: sourceware.org; auth=none
- References: <1407935535-27978-1-git-send-email-omair dot javaid at linaro dot org> <1407935535-27978-5-git-send-email-omair dot javaid at linaro dot org> <CANu=DmipyTp=mBvWkYJ22qMboYfsj7x3LmWZZZWYGyFdnKYqDw at mail dot gmail dot com> <CANW4E-23kaGS-76jb-NfezZLFoK7rh-2asi5X+JbMHKVXr1P2Q at mail dot gmail dot com>
On 08/27/2014 10:21 AM, Omair Javaid wrote:
> + while (memory_count)
> + {
> + while (reg_count)
Not implicit boolean coercion please. Write
'memory_count != 0' or 'memory_count > 0'.
>>> >> + /* VLDR Vector load register. */
>>> >> + else if ((opcode & 0x13) == 0x11)
>>> >> + {
>>> >> + uint8_t single_reg = 0;
>>> >> + uint8_t special_case;
>> >
>> > Is there some missing code here? Should there be a TODO comment?
> Seems like a bit of code missing here will update it in the final patch.
It's kind of hard to review code that we don't see... :-)
Please post the updated patch.
> Ping! Kindly provide your feedback any further comments will help me
> approve this patch series.
This is OK if Will is happy with the updated patch.
Thanks,
Pedro Alves