This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5 v7] Introduce common-debug.h
- From: Steve Ellcey <sellcey at mips dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Tue, 19 Aug 2014 16:22:10 -0700
- Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
- Authentication-results: sourceware.org; auth=none
- References: <20140819091220 dot GB6493 at blade dot nx>
On Tue, 2014-08-19 at 10:12 +0100, Gary Benson wrote:
> > > 2014-08-13 Tom Tromey <tromey@redhat.com>
> > > Gary Benson <gbenson@redhat.com>
> > >
> > > * common/common-debug.h: New file.
> > > * common/common-debug.c: Likewise.
> > > * debug.c: Likewise.
> > > * Makefile.in (SFILES): Add common/common-debug.c.
> > > (HFILES_NO_SRCDIR): Add common/common-debug.h.
> > > (COMMON_OBS): Add common-debug.o and debug.o.
> > > (common-debug.o): New rule.
> > > * common/common-defs.h: Include common-debug.h.
> > > * common/agent.c (debug_agent_printf): New function.
> > > (DEBUG_AGENT): Redefine.
> > > * nat/i386-dregs.c (debug_printf): Undefine.
I just built gdb for mips (mips-linux-gnu and mips-mti-linux-gnu) and it
died with:
/local/home/sellcey/gcc/non_mti_linux/src/binutils-gdb/sim/mips/../common/sim-trace.c:1326: multiple definition of `debug_printf'
common-debug.o:/local/home/sellcey/gcc/non_mti_linux/src/binutils-gdb/gdb/common/common-debug.c:31: first defined here
collect2: ld returned 1 exit status
make[1]: *** [gdb] Error 1
I am assuming it has something to do with this patch.
Steve Ellcey
sellcey@mips.com