This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] infcmd.c (attach_command): Improve comment.


On 07/29/2014 10:32 PM, Doug Evans wrote:
> Hi.
> 
> I always have to re-lookup what target_attach_no_wait means,
> and what targets set it to non-zero, every time I look at this code.
> 
> This patch is a modest attempt at clearing things up for me.
> [maybe a good example of why double negatives should be avoided,
> in this case "! no-wait".  maybe not.]

Looks obviously good to me.

-- 
Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]