This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch+7.8] PR testsuite/16602 runtest deletes files in-src-tree
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 15 Jul 2014 21:33:11 +0200
- Subject: Re: [patch+7.8] PR testsuite/16602 runtest deletes files in-src-tree
- Authentication-results: sourceware.org; auth=none
- References: <20140712210532 dot GA8417 at host2 dot jankratochvil dot net> <53C4F3FC dot 4070601 at redhat dot com>
On Tue, 15 Jul 2014 11:27:24 +0200, Pedro Alves wrote:
> I miss some explanation in the commit log / email description
> of the problem.
>
> IIUC, when testing out of srcdir, the remote_download call on
> non-remote hosts copies the file, and then the "remote_file delete"
> call deletes the copy. But when testing in srcdir, I'm
> guessing remote_download copies the file over itself
> (or does nothing), and then the "remote_file delete" call
> deletes the source file, because it's the same path as the
> destination of the previous download.
>
> Correct?
Correct.
> and will miss deleting the file on non-srcdir testing.
I agree my patch has this bug.
> Maybe that's fine. Maybe we should just never delete
> these files, even on remote host testing. Dunno.
I have no opinion what should happen in all the other cases, there are many
options how the testsuite could behave. Just currently it is broken for the
IMO most simple srcdir builds.
Jan