This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c
- From: Pedro Alves <palves at redhat dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gbenson at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 27 Jun 2014 11:54:09 +0100
- Subject: Re: [PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c
- Authentication-results: sourceware.org; auth=none
- References: <1403860209-475-1-git-send-email-gbenson at redhat dot com> <201406270928 dot s5R9SZPG020219 at glazunov dot sibelius dot xs4all dot nl> <53AD49F1 dot 70709 at redhat dot com>
On 06/27/2014 11:39 AM, Pedro Alves wrote:
> The resulting #ifdefery quite reasonable, IMNSHO -- it'd be bad if there
> were lots of different combinations of symbols we'd have to #ifdef on,
> but there's really only a few #ifdef __x86_64__. So if it's
> spaghetti, it's still dry, raw, straight and neatly lined up
> in the package. :-)
Ah, I found one bit where there's more #ifdefery than necessary.
So the spaghetti did catch some moisture. :-)
Gary, please compare your resulting x86_linux_read_description
with gdbserver's x86_linux_read_description. Notice how it
has fewer #ifdef blocks. Could you rework your version of the
function in that direction please?
Thanks,
--
Pedro Alves