This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/3] make_corefile_notes: have caller free returned memory
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 24 Jun 2014 13:58:51 +0100
- Subject: Re: [PATCH v2 1/3] make_corefile_notes: have caller free returned memory
- Authentication-results: sourceware.org; auth=none
- References: <1403599872-25299-1-git-send-email-markus dot t dot metzger at intel dot com>
On 06/24/2014 09:51 AM, Markus Metzger wrote:
> The various make_corefile_notes implementations for gdbarch as well as target
> currently make an xfree cleanup on the data they return. This causes problems
> when trying to put a TRY_CATCH around the make_corefile_notes call.
> Specifically, we get a stale cleanup error in restore_my_cleanups.
>
> Omit the make_cleanup and have the caller free the memory.
>
> 2014-06-24 Markus Metzger <markus.t.metzger@intel.com>
>
> * fbsd-nat.c (fbsd_make_corefile_notes): Remove make_cleanup call.
> * gcore.c (write_gcore_file): Free memory returned from
> make_corefile_notes.
> * linux-tdep.c (linux_make_corefile_notes): Remove make_cleanup call.
> * procfs.c (procfs_make_note_section): Remove make_cleanup call.
OK.
--
Pedro Alves