This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Move shared native target specific code to gdb/nat


On 06/20/2014 12:36 PM, Gary Benson wrote:
> diff --git a/gdb/i387-tdep.c b/gdb/i387-tdep.c
> index c58a000..5b2c025 100644
> --- a/gdb/i387-tdep.c
> +++ b/gdb/i387-tdep.c
> @@ -32,7 +32,7 @@
>  
>  #include "i386-tdep.h"
>  #include "i387-tdep.h"
> -#include "i386-xstate.h"
> +#include "nat/i386-xstate.h"

This shows that the file isn't really native target
specific -- a tdep including nat files wouldn't be
right.  Turns out i386-xstate.h just defines ABI-style
constants.  So leave it in common/.

On 06/20/2014 12:36 PM, Gary Benson wrote:
> --- a/gdb/common/linux-btrace.c
> +++ b/gdb/nat/linux-btrace.c
> @@ -25,13 +25,13 @@
>  #include "defs.h"
>  #endif
>
> -#include "linux-btrace.h"
> +#include "nat/linux-btrace.h"

Both the .c file and its header are in the same directory,
so this change isn't really necessary.  I wonder what's the
best policy here.

Otherwise looks good to me.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]