This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 0/4 v2] Refactor shared code in i386-{nat,low}.[ch]


Hi all,

This series continues on from the refactoring series I posted
yesterday and partially committed today:

 1 - Partially revert 4be83cc2b28ea09aa8ff789839e6520df60836f8

     Pedro spotted that i386_{insert,remove}_hw_breakpoint could be
     further refactored.  Patch 2 of this series does precisely that.
     This change means a number of functions I made nonstatic do not
     now have to be.  This patch reverts that change.  I apologise
     for this noise but the end result is better.

 2 - Refactor i386_{insert,remove}_hw_breakpoint

     As above.

 3 - Create nat/i386-dregs.c

     This patch moves all the code from the various files into
     the new file nat/i386-dregs.c and adds it to the buildsystem.

 4 - Directly call i386-dregs functions

     This patch is a small tidyup of i386-nat.c.

Is this ok to commit?

Thanks,
Gary

--
http://gbenson.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]