This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Terry Guo > Sent: Thursday, June 12, 2014 11:40 AM > To: lgustavo@codesourcery.com; 'Will Newton' > Cc: gdb-patches@sourceware.org > Subject: RE: [Patch]Clean up the XML files for ARM > > > > > -----Original Message----- > > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > owner@sourceware.org] On Behalf Of Luis Machado > > Sent: Wednesday, June 11, 2014 7:25 PM > > To: Terry Guo; 'Will Newton' > > Cc: gdb-patches@sourceware.org > > Subject: Re: [Patch]Clean up the XML files for ARM > > > > On 06/11/2014 10:12 AM, Terry Guo wrote: > > > > > > > > >> -----Original Message----- > > >> From: Will Newton [mailto:will.newton@linaro.org] > > >> Sent: Wednesday, June 11, 2014 4:16 PM > > >> To: Terry Guo > > >> Cc: gdb-patches@sourceware.org > > >> Subject: Re: [Patch]Clean up the XML files for ARM > > >> > > >> On 11 June 2014 07:46, Terry Guo <terry.guo@arm.com> wrote: > > >>> Hi There, > > >>> > > >>> Under folder gdb/features we are having more and more ARM related > > >>> XML > > >> files. > > >>> This patch intends to move those ARM XML files into a new folder > > >>> named > > >> arm. > > >>> All the references to those files are now prefixed with folder name > arm. > > >>> Please be noted that this doesn't include AArch64 XML files so far. > > >>> Is it ok to GDB trunk? > > >>> > > >>> BR, > > >>> Terry > > >>> > > >>> 2014-06-11 Terry Guo <terry.guo@arm.com> > > >>> > > >>> * features/arm-core.xml: Move to ... > > >>> * features/arm/arm-core.xml: ... here. > > >>> * features/arm-fpa.xml: Move to ... > > >>> * features/arm/arm-fpa.xml: ... here. > > >>> * features/arm-m-profile.xml: Move to ... > > >>> * features/arm/arm-m-profile.xml: ... here. > > >>> * features/arm-vfpv2.xml: Move to ... > > >>> * features/arm/arm-vfpv2.xml: ... here. > > >>> * features/arm-vfpv3.xml: Move to ... > > >>> * features/arm/arm-vfpv3.xml: ... here. > > >>> * features/arm-with-iwmmxt.xml: Move to ... > > >>> * features/arm/arm-with-iwmmxt.xml: ... here. > > >>> * features/arm-with-iwmmxt.c: Move to ... > > >>> * features/arm/arm-with-iwmmxt.c: ... here. > > >>> * features/arm-with-m.xml: Move to ... > > >>> * features/arm/arm-with-m.xml: ... here. > > >>> * features/arm-with-m.c: Move to ... > > >>> * features/arm/arm-with-m.c: ... here. > > >>> * features/arm-with-m-fpa-layout.xml: Move to ... > > >>> * features/arm/arm-with-m-fpa-layout.xml: ... here. > > >>> * features/arm-with-m-fpa-layout.c: Move to ... > > >>> * features/arm/arm-with-m-fpa-layout.c: ... here. > > >>> * features/arm-with-m-vfp-d16.xml: Move to ... > > >>> * features/arm/arm-with-m-vfp-d16.xml: ... here. > > >>> * features/arm-with-m-vfp-d16.c: Move to ... > > >>> * features/arm/arm-with-m-vfp-d16.c: ... here. > > >>> * features/arm-with-neon.xml: Move to ... > > >>> * features/arm/arm-with-neon.xml: ... here. > > >>> * features/arm-with-neon.c: Move to ... > > >>> * features/arm/arm-with-neon.c: ... here. > > >>> * features/arm-with-vfpv2.xml: Move to ... > > >>> * features/arm/arm-with-vfpv2.xml: ... here. > > >>> * features/arm-with-vfpv2.c: Move to ... > > >>> * features/arm/arm-with-vfpv2.c: ... here. > > >>> * features/arm-with-vfpv3.xml: Move to ... > > >>> * features/arm/arm-with-vfpv3.xml: ... here. > > >>> * features/arm-with-vfpv3.c: Move to ... > > >>> * features/arm/arm-with-vfpv3.c: ... here. > > >>> * features/Makefile: Use new paths to refer ARM files. > > >>> * arm-tdep.c: Use new paths to include files. > > >> > > >> It seems like we have duplicate "arm" in some of the names now, it > > >> might be a good cleanup to rename, e.g.: > > >> > > >> features/arm/arm-vfpv3.xml -> features/arm/vfpv3.xml > > >> > > > > > > Thanks for comments. But files in folder i386 and rs6000 are same as mine. > > Maybe there are reasons to do so. > > > > > > For example: > > > > > > i386/ > > > i386/i386-mmx.c > > > i386/32bit-avx512.xml > > > i386/x32-avx512.xml > > > i386/x32-avx512-linux.c > > > i386/32bit-sse.xml > > > i386/32bit-mpx.xml > > > i386/i386-avx-linux.xml > > > i386/i386-mpx.c > > > i386/i386-mpx-linux.xml > > > i386/x32-core.xml > > > i386/64bit-core.xml > > > i386/i386.xml > > > > > > ./rs6000/powerpc-isa205-altivec64l.xml > > > ./rs6000/powerpc-e500l.c > > > ./rs6000/powerpc-altivec64l.c > > > ./rs6000/powerpc-603.xml > > > ./rs6000/powerpc-602.xml > > > ./rs6000/power64-core.xml > > > ./rs6000/powerpc-64.c > > > ./rs6000/powerpc-altivec64.c > > > ./rs6000/powerpc-505.xml > > > > > > BR, > > > Terry > > > > I think one of the reasons for having duplication there is that nobody > > commented about it, like Will. > > > > I'd go for the cleaner names without the duplication. The duplication > certainly > > doesn't add anything to it. > > > > Hi Luis and Will, > > Thanks both of you. This clears my concerns. I will update this per your > comments. > > BR, > Terry > > Hi, Attachment is an updated patch with the removal of arm in filename. There is also a change to gdb regression test case. Is this one OK? BR, Terry Updated ChangeLog: 2014-06-16 Terry Guo <terry.guo@arm.com> * features/arm-core.xml: Move to ... * features/arm/core.xml: ... here. * features/arm-fpa.xml: Move to ... * features/arm/fpa.xml: ... here. * features/arm-m-profile.xml: Move to ... * features/arm/m-profile.xml: ... here. * features/arm-vfpv2.xml: Move to ... * features/arm/vfpv2.xml: ... here. * features/arm-vfpv3.xml: Move to ... * features/arm/vfpv3.xml: ... here. * features/arm-with-iwmmxt.xml: Move to ... * features/arm/with-iwmmxt.xml: ... here. * features/arm-with-iwmmxt.c: Move to ... * features/arm/with-iwmmxt.c: ... here. * features/arm-with-m.xml: Move to ... * features/arm/with-m.xml: ... here. * features/arm-with-m.c: Move to ... * features/arm/with-m.c: ... here. * features/arm-with-m-fpa-layout.xml: Move to ... * features/arm/with-m-fpa-layout.xml: ... here. * features/arm-with-m-fpa-layout.c: Move to ... * features/arm/with-m-fpa-layout.c: ... here. * features/arm-with-m-vfp-d16.xml: Move to ... * features/arm/with-m-vfp-d16.xml: ... here. * features/arm-with-m-vfp-d16.c: Move to ... * features/arm/with-m-vfp-d16.c: ... here. * features/arm-with-neon.xml: Move to ... * features/arm/with-neon.xml: ... here. * features/arm-with-neon.c: Move to ... * features/arm/with-neon.c: ... here. * features/arm-with-vfpv2.xml: Move to ... * features/arm/with-vfpv2.xml: ... here. * features/arm-with-vfpv2.c: Move to ... * features/arm/with-vfpv2.c: ... here. * features/arm-with-vfpv3.xml: Move to ... * features/arm/with-vfpv3.xml: ... here. * features/arm-with-vfpv3.c: Move to ... * features/arm/with-vfpv3.c: ... here. * features/xscale-iwmmxt.xml: Move to ... * features/arm/xscale-iwmmxt.xml: ... here. * features/Makefile: Use new paths to refer ARM files. * arm-tdep.c: Use new paths to include files. gdb/gdbserver/ChangeLog: 2014-06-16 Terry Guo <terry.guo@arm.com> * configure.srv: Use new paths to refer ARM XML files. 2014-06-16 Terry Guo <terry.guo@arm.com> * gdb.xml/tdesc-regs.exp (arm): Use new path to refer ARM XML file.
Attachment:
gdb-clean-xml-for-arm-v2.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |