This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix c++/16253 (tag/variable name collision)
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 28 May 2014 10:55:38 -0700
- Subject: Re: [RFA] Fix c++/16253 (tag/variable name collision)
- Authentication-results: sourceware.org; auth=none
- References: <532C810F dot 7010809 at redhat dot com> <20140326134048 dot GA24501 at adacore dot com> <5346E8EA dot 1070705 at redhat dot com> <87lhvdnd1p dot fsf at fleche dot redhat dot com>
On Thu, Apr 10, 2014 at 1:29 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> I am reposting the entire patch for review. The only difference
> Keith> between this and the original version is the exclusion of the patch
> Keith> mentioned above.
>
> Thanks Keith.
>
> I like this patch quite a lot.
> It gets rid of symbol_matches_domain -- that's fantastic.
Awesome indeed.
Alas it trips over gdb's sucky symbol lookup and introduces a perf regression.
info fun ^foo::(anonymous namespace)
goes from about a minute to a very long time (longer than I wanted to wait :-)).
["foo" is renamed to protect the innocent. 1/2 :-)]
I've reopened 16253 and filed 16994.
One possibility is to revert the patch for 7.8.
I've confirmed doing that removes the perf regression.
I'd like to see if we can take a small step to fixing gdb's symbol
lookup that will fix the perf regression.