This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.
- From: Gary Benson <gbenson at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Andrew Burgess <aburgess at broadcom dot com>, Ian Lance Taylor <iant at google dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 22 May 2014 17:02:08 +0100
- Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.
- Authentication-results: sourceware.org; auth=none
- References: <1399646123-9960-1-git-send-email-aburgess at broadcom dot com> <CAKOQZ8zCbzpkwR_HkraUsNoDHEPt2pUXsQEk8kf_Mc43DGTHJw at mail dot gmail dot com> <536E7A72 dot 1040203 at broadcom dot com> <CAKOQZ8wBvHe6KdWDuipPmSu=6hrJZ88xDHMyP_B2sHc-4L3qNg at mail dot gmail dot com> <20140514090125 dot GA4974 at blade dot nx> <537337AF dot 3020806 at broadcom dot com> <20140514142016 dot GA32660 at blade dot nx> <87a9aavxdr dot fsf at kepler dot schwinge dot homeip dot net>
Hi Thomas,
Thomas Schwinge wrote:
> In GCC, I'm consistenly seeing the following new failure:
>
> ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected
> FAIL at line 4350, options --format=auto --no-params:
> in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> out: (null)
> exp:
> ./test-demangle: 895 tests, 1 failures
> make[2]: *** [check-cplus-dem] Error 1
>
> The patch was committed incompletely; I added the missing last line in
> r210803:
[snip]
> @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std
> --format=auto --no-params
> _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
I thought that extra line was a mistake; I thought each test was
precisely three lines:
# options
# input to be demangled
# expected output
What is the extra line here?
Thanks,
Gary
--
http://gbenson.net/