This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] constify to_attach
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 21 May 2014 15:35:59 -0600
- Subject: Re: [PATCH] constify to_attach
- Authentication-results: sourceware.org; auth=none
- References: <1400696455-29563-1-git-send-email-tromey at redhat dot com> <87mwebhsc2 dot fsf at fleche dot redhat dot com> <20140521212227 dot GN22822 at adacore dot com>
Joel> For this sort of search, it would be helpful to have a convention
Joel> that we either use var->method to set the field, or else put the name
Joel> of the field in comment next to the assignment like we do with
Joel> the language vector. That really makes it easier to find them;
Joel> otherwise, one has to use code analyzers, which sometimes don't
Joel> work when you can't compile the file first.
Yeah. C99 designated initializers are really nice for this reason.
Tom