This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 6/8] gdbserver build-id attribute generator
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Tue, 20 May 2014 08:40:33 -0600
- Subject: Re: [PATCH v5 6/8] gdbserver build-id attribute generator
- Authentication-results: sourceware.org; auth=none
- References: <20140319223004 dot 14668 dot 20989 dot stgit at host1 dot jankratochvil dot net> <20140319223115 dot 14668 dot 73456 dot stgit at host1 dot jankratochvil dot net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> producer part of the new "build-id" XML attribute.
I can't really claim to understand all of this patch.
What I do understand looks reasonable, and I'm prepared to approve it
given its history, etc.
However:
Jan> -<!ATTLIST library-list-svr4 version CDATA #FIXED "1.0">
Jan> -<!ATTLIST library-list-svr4 main-lm CDATA #IMPLIED>
Jan> +<!ATTLIST library-list-svr4 version CDATA #FIXED "1.0">
Jan> +<!ATTLIST library-list-svr4 main-lm CDATA #IMPLIED>
I am concerned about versioning of the XML.
Is it correct to keep the same version number?
If so -- why?
Perhaps we consider it compatible to add attributes.
I really don't know; nor did I find anything in the documentation.
So at the very least this needs an update to the manual to warn
future users.
Tom