This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: Taimoor Mirza <tmirza at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 7 May 2014 06:25:11 -0700
- Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
- Authentication-results: sourceware.org; auth=none
- References: <1399448485-1740-1-git-send-email-tmirza at codesourcery dot com> <CANu=DmgMWP=dr=9xxQxcnFC-99M-BjdZa9JQa8vHM_w8Ythkxg at mail dot gmail dot com>
> > 2014-05-06 Taimoor Mirza <tmirza@codesourcery.com>
> >
> > gdb/
> > * arm-tdep.c (thumb_analyze_prologue): Fix offset calculation for
> > ldr.w and ldrd instructions.
[...]
> This looks good to me, assuming the testsuite was run with no regressions.
Thanks, Will, for reviewing the patch. I concur on both counts:
patch is approved, but can you please also confirm how the patch
was tested?
Thank you,
--
Joel