This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/12] Generalize varobj iterator

From: Keith Seitz <keiths at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
Date: Wed, 23 Apr 2014 12:24:21 -0700
Subject: Re: [PATCH 02/12] Generalize varobj iterator
Authentication-results: sourceware.org; auth=none
References: <1392367471-13527-1-git-send-email-yao at codesourcery dot com> <1392367471-13527-3-git-send-email-yao at codesourcery dot com>

On 02/14/2014 12:44 AM, Yao Qi wrote:

  V2:
   - Fix a missing cleanup.
   - Fix typos.
   - Use XNEW.
   - Check against NULL explicitly.
   - Update copyright year for new added files.

gdb:

2014-02-14  Pedro Alves  <pedro@codesourcery.com>
	    Yao Qi  <yao@codesourcery.com>

	* Makefile.in (SUBDIR_PYTHON_OBS): Add "py-varobj.o".
	(SUBDIR_PYTHON_SRCS): Add "python/py-varobj.c".
	(HFILES_NO_SRCDIR): Add "varobj-iter.h".
	(py-varobj.o): New rule.
	* python/py-varobj.c: New file.
	* python/python-internal.h (py_varobj_get_iterator): Declare.
	* varobj-iter.h: New file.
	* varobj.c: Include "varobj-iter.h"
	(struct varobj) <child_iter>: Change its type from "PyObject *"
	to "struct varobj_iter *".
	<saved_item>: Likewise.
	[HAVE_PYTHON] (varobj_ensure_python_env): Make it extern.
	[HAVE_PYTHON] (varobj_get_iterator): New function.
	(update_dynamic_varobj_children) [HAVE_PYTHON]: Move
	python-specific code to python/py-varobj.c.
	(install_visualizer): Call varobj_iter_delete instead of
	Py_XDECREF.
	* varobj.h (varobj_ensure_python_env): Declare.

This looks okay to me, too. I recommend a maintainer give this a finalreview.


Keith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]