Re: [RFA testsuite 5/5] Update all callers

[Keith Seitz <keiths at redhat dot com>]

On 04/17/2014 01:46 PM, Tom Tromey wrote:
> > > > > > "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> 2014-04-15  Keith Seitz  <keiths@redhat.com>
> Keith> 	* gdb.mi/mi-break.exp: Remove unused globals,
> Keith> 	update mi_create_breakpoint usage, and use mi_make_breakpoint_table.
> Keith> 	All callers updated.
> Keith> 	* gdb.mi/mi-dprintf.exp: Use variable to track command
> Keith> 	number.
> Keith> 	Update all callers of mi_create_breakpoint and use
> Keith> 	mi_make_breakpoint_table.
> Keith> 	Remove any unused global variables.
> Keith> 	* gdb.mi/mi-nonstop.exp: Likewise.
> Keith> 	* gdb.mi/mi-nsintrall.exp: Likewise.
> Keith> 	* gdb.mi/mi-nsmoribund.exp: Likewise.
> Keith> 	* gdb.mi/mi-nsthrexec.exp: Likewise.
> Keith> 	* gdb.mi/mi-reverse.exp: Likewise.
> Keith> 	* gdb.mi/mi-simplerun.exp: Likewise.
> Keith> 	* gdb.mi/mi-stepn.exp: Likewise.
> Keith> 	* gdb.mi/mi-syn-frame.exp: Likewise.
> Keith> 	* gdb.mi/mi-until.exp: Likewise.
> Keith> 	* gdb.mi/mi-var-cp.exp: Likewise.
> Keith> 	* gdb.mi/mi-var-display.exp: Likewise.
> Keith> 	* gdb.mi/mi2-amd64-entry-value.exp: Likewise.
> Keith> 	* gdb.mi/mi2-var-child.exp: Likewise.
> Keith> 	* lib/mi-support.exp: Likewise.
>
> This is ok.

Recently a new test using mi_create_breakpoint was introduced. I'll be 
pushing this (as obvious) when I commit the whole series.

Keith

diff --git a/gdb/testsuite/gdb.mi/mi-vla-c99.exp 
b/gdb/testsuite/gdb.mi/mi-vla-c99.exp
index 618e8ab..ee78700 100644
--- a/gdb/testsuite/gdb.mi/mi-vla-c99.exp
+++ b/gdb/testsuite/gdb.mi/mi-vla-c99.exp
@@ -40,9 +40,10 @@ mi_gdb_load ${binfile}

 set bp_lineno [gdb_get_line_number "vla-filled"]

-mi_create_breakpoint "-t vla.c:$bp_lineno" 1 "del" "func" \
-             ".*vla.c" $bp_lineno $hex \
-             "insert breakpoint at line $bp_lineno after vla is filled"
+mi_create_breakpoint "-t vla.c:$bp_lineno" \
+    "insert breakpoint at line $bp_lineno after vla is filled" \
+    -function func -line $bp_lineno -file ".*vla.c" -disp del
+
 mi_run_cmd
 mi_expect_stop "breakpoint-hit" "func" "\{name=\"n\",value=\"5\"\}" \
                ".*vla.c" "$bp_lineno" { "" "disp=\"del\"" } \


testsuite/ChangeLog
2014-04-23  Keith Seitz  <keiths@redhat.com>

        * gdb.mi/mi-vla-c99.exp: Update mi_create_breakpoint usage.