This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 01/12] Use 'struct varobj_item' to represent name and value pair

From: Keith Seitz <keiths at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
Date: Wed, 23 Apr 2014 11:16:14 -0700
Subject: Re: [PATCH 01/12] Use 'struct varobj_item' to represent name and value pair
Authentication-results: sourceware.org; auth=none
References: <1392367471-13527-1-git-send-email-yao at codesourcery dot com> <1392367471-13527-2-git-send-email-yao at codesourcery dot com>

On 02/14/2014 12:44 AM, Yao Qi wrote:

  V2:
  - Fix changelog entry.
  - Fix one grammatical mistake.

gdb:

2014-02-14  Yao Qi  <yao@codesourcery.com>

	* varobj.c (struct varobj_item): New structure.
	(create_child_with_value): Update declaration.
	(varobj_add_child): Replace arguments 'name' and 'value' with
	'item'.  All callers updated.
	(install_dynamic_child): Likewise.
	(update_dynamic_varobj_children): Likewise.
	(varobj_add_child): Likewise.
	(create_child_with_value): Likewise.

This looks good to me. I recommend a maintainer look this over for finalreview/approval.


Keith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]