This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] btrace: control memory access during replay
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: palves at redhat dot com, jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 04 Apr 2014 12:16:42 +0300
- Subject: Re: [rfc] btrace: control memory access during replay
- Authentication-results: sourceware.org; auth=none
- References: <1396601781-25010-1-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 4 Apr 2014 10:56:21 +0200
>
> The btrace record target does not trace data. We therefore do not allow
> accessing read-write memory during replay.
>
> In some cases, this might be useful to advanced users, though, who we assume
> to know what they are doing.
>
> Add a set|show command pair to turn this memory access restriction off.
>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> 2014-04-04 Markus Metzger <markus.t.metzger@intel.com>
>
> * record-btrace.c (set_record_btrace_cmdlist)
> (show_record_btrace_cmdlist, cmd_set_record_btrace)
> (cmd_show_record_btrace): New.
> (_initialize_record_btrace): Add commands.
> * NEWS: Announce it.
>
> testsuite/
> * gdb.btrace/data.exp: Test it.
>
> doc/
> * gdb.texinfo: Document it.
The ChangeLog entry should state the name(s) of the node(s) in which
you make changes.
Other than that, the documentation parts are approved. However, I
wonder whether "allow-memory-access" is a good name for a setting
which actually allows access to writable portion of the memory. IOW,
even when the value is OFF, we do allow access to memory, just not the
writable portion of it.
Thanks.