This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: target-delegates.c needs some TLC [was Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN]
- From: Yao Qi <yao at codesourcery dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, Hui Zhu <hui_zhu at mentor dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Mon, 10 Mar 2014 10:45:13 +0800
- Subject: Re: target-delegates.c needs some TLC [was Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN]
- Authentication-results: sourceware.org; auth=none
- References: <CAP9bCMTwuW_2_3Dn+JynOxtgyv862ghs8GZgOyUm8MbEcfb=Tw at mail dot gmail dot com>
On 03/06/2014 01:20 PM, Doug Evans wrote:
> While I realize we don't want to require perl for building gdb (and I
> for one would never advocate it), I wonder if we can do at least a bit
> better.
perl is required by git, and GDB source is version controlled by git.
I assume that most of the host machine used for gdb development have
git and perl installed. People may get source from release, and
generate patch on top of it (without git/perl installed). It isn't
common, is it?
Anyway, we can check whether perl is installed. If perl is installed,
run make-target-delegates during make and error out if new-generated
target-delegates.c is different from the one in gdb source. Is it good?
If yes, I'll submit a patch for this.
Using --enable-maintainer-mode or adding new --enable-foo option isn't
appealing to me.
--
Yao (éå)