This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Error on bad count number
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 6 Mar 2014 17:52:45 +0800
- Subject: Re: [PATCH 2/4] Error on bad count number
- Authentication-results: sourceware.org; auth=none
- References: <1394023608-10761-1-git-send-email-yao at codesourcery dot com> <1394023608-10761-3-git-send-email-yao at codesourcery dot com> <20140305142939 dot GB16858 at adacore dot com> <531749BA dot 8050806 at redhat dot com>
On 03/05/2014 11:58 PM, Pedro Alves wrote:
> I had the same thought. I wondered whether 0 was meant to
> remove the enable count, but the docs don't say anything
> about it. Is there another way to disable the count, and
> bring back the disposition to enabled? If not, I wonder
> whether using 0 for that would be a good idea?
If 0 is potentially acceptable, I am fine to keep it. I'll back
to change get_number to return negative for invalid input, to
differentiate valid number zero and invalid input.
--
Yao (éå)