This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR16508
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 05 Mar 2014 20:33:44 +0000
- Subject: Re: [PATCH] Fix PR16508
- Authentication-results: sourceware.org; auth=none
- References: <1392447370-22318-1-git-send-email-yao at codesourcery dot com> <87lhwo76qv dot fsf at fleche dot redhat dot com>
On 03/05/2014 08:03 PM, Tom Tromey wrote:
> Yao> +if [prepare_for_testing $expfile $executable $srcfile \
> Yao> + [list debug]] {
> Yao> + untested "failed to prepare for trace tests"
>
> prepare calls untested for you, so no need to do it again.
Note that the first argument to prepare_for_testing is
what is passed to untested (and really only used for that),
so a better alternative even is to do:
if [prepare_for_testing "failed to prepare for trace tests" \
$executable $srcfile [list debug]] {
Although we do that all over the place, passing $expfile
to untested is useless, as that information will be
in the gdb.sum before UNTESTED anyway.
I'd support us starting to use this pattern more.
--
Pedro Alves