Re: [PATCH, doc RFA] New option: set print symbol-loading

[Eli Zaretskii <eliz at gnu dot org>]

> From: Doug Evans <dje@google.com>
> Date: Mon, 24 Feb 2014 15:50:40 -0800
> 
> I added this patch a few years ago, but
> I got uncomfortable with keeping it upstream.
> https://sourceware.org/ml/gdb-patches/2008-07/msg00165.html
> 
> It's proven quite useful here over the years (and continues to be useful),
> so I'm resubmitting it (it's changed a bit since then, but the main idea
> is still the same).
> 
> The motivation for the patch is that it's not helpful to have 100s (or 1000s)
> of "Reading symbols from" messages printed on the screen.
> 
> Note: This patch is written as if the following patch hasn't been applied:
> https://sourceware.org/ml/gdb-patches/2014-02/msg00742.html
> I'll update the patch before committing based on whether it does get applied.
> 
> Regression tested on amd64-linux.
> 
> 2014-02-24  Doug Evans  <dje@google.com>
> 
> 	New option "set print symbol-loading".
> 	* NEWS: Mention it.
> 	* solib.c (solib_read_symbols): Only print symbol loading messages
> 	if requested.
> 	(solib_add): If symbol loading is in "brief" mode, notify user
> 	symbols are being loaded.
> 	(reload_shared_libraries_1): Ditto.
> 	* symfile.c (print_symbol_loading_off): New static global.
> 	(print_symbol_loading_brief): New static global.
> 	(print_symbol_loading_full): New static global.
> 	(print_symbol_loading_enums): New static global.
> 	(print_symbol_loading): New static global.
> 	(print_symbol_loading_p): New function.
> 	(symbol_file_add_with_addrs): Only print symbol loading messages
> 	if requested.
> 	(_initialize_symfile): Register "print symbol-loading" set/show
> 	command.
> 	* symfile.h (print_symbol_loading_p): Declare.
> 
> 	doc/
> 	* gdb.texinfo (Symbols): Document set/show print symbol-loading.
> 
> 	testsuite/
> 	* gdb.base/print-symbol-loading-lib.c: New file.
> 	* gdb.base/print-symbol-loading-main.c: New file.
> 	* gdb.base/print-symbol-loading.exp: New file.

OK for the documentation parts.

Thanks.