This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/8] Adjust read_value_memory to use to_xfer_partial
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Feb 2014 11:16:25 +0000
- Subject: Re: [PATCH 7/8] Adjust read_value_memory to use to_xfer_partial
- Authentication-results: sourceware.org; auth=none
- References: <1392185152-21220-1-git-send-email-yao at codesourcery dot com> <1392185152-21220-8-git-send-email-yao at codesourcery dot com> <53060103 dot 8060301 at redhat dot com> <53097071 dot 501 at codesourcery dot com>
On 02/23/2014 03:52 AM, Yao Qi wrote:
>> /* nothing */;
>> else if (status == TARGET_XFER_E_UNAVAILABLE)
>> mark_value_bytes_unavailable (val, embedded_offset + xfered,
>> xfered_len);
>> else if (status == TARGET_XFER_EOF)
>> memory_error (TARGET_XFER_E_IO, memaddr + xfered);
>> else
>> memory_error (status, memaddr + xfered);
>>
>> xfered += xfered_len;
>> QUIT;
>> }
>>
>> and now all future unhandled statuses fall through to
>> memory_error.
>
> OK, update patch as you suggested. I'll get rid of
> TARGET_XFER_STATUS_ERROR_P in a follow-up patch.
Great, thanks.
>> (Hmm, the _E_ in TARGET_XFER_E_UNAVAILABLE is now starting
>> to look a little odd and confusing to me. E.g., it's not
>> really an error in this case. I'm pondering renaming it to
>> TARGET_XFER_UNAVAILABLE.)
>
> It isn't an error. Will rename it in a follow-up patch too.
Thank you!
--
Pedro Alves