This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] guile: Add 'history-push!' procedure
- From: Eli Zaretskii <eliz at gnu dot org>
- To: ludo at gnu dot org (Ludovic CourtÃs)
- Cc: gdb-patches at sourceware dot org, xdje42 at gmail dot com
- Date: Thu, 20 Feb 2014 18:28:51 +0200
- Subject: Re: [PATCH] guile: Add 'history-push!' procedure
- Authentication-results: sourceware.org; auth=none
- References: <871tz06o4x dot fsf at gnu dot org> <83txbv69z9 dot fsf at gnu dot org> <877g8q7p80 dot fsf at gnu dot org>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: ludo@gnu.org (Ludovic CourtÃs)
> Cc: gdb-patches@sourceware.org, xdje42@gmail.com
> Date: Wed, 19 Feb 2014 22:43:43 +0100
>
> >> +@deffn {Scheme Procedure} history-push! value
> >> +Push @var{value}, an instance of @code{<gdb:value>}, to @value{GDBN}'s
> >> +value history.
> >
> > I think we should explain what "push" means in this context. It is
> > not self-evident.
>
> Right. How about s/push/append/? (In the procedure name as well.)
Fine with me.
> >> Return its index in the history, or @code{#f} if it is
> >> +not saved.
> >
> > Why would it not be saved?
>
> Good question. The doc above ârecord_latest_valueâ mentions that it can
> return -1, but I see no path leading to that. Can I assume that -1 is
> never returned?
I don't know, but if that is your reading, I see no reason not to.
> How about simply this:
>
> Using this function is useful to provide convenient access to values
> manipulated by a Guile extension of GDB.
I suggest
Putting into history values returned by Guile extensions will allow
the user convenient access to those values via CLI history
facilities.
Thanks.