This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Correct comment in mi_cmd_data_write_memory_bytes
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 11 Feb 2014 07:56:57 +0400
- Subject: Re: [PATCH] Correct comment in mi_cmd_data_write_memory_bytes
- Authentication-results: sourceware.org; auth=none
- References: <52F915EB dot 9010802 at ericsson dot com>
> This confused me for a moment, so I thought it would be worth
> correcting.
Absolutely, thank you!
> gdb/Changelog:
>
> 2014-02-10 Simon Marchi <simon.marchi@ericsson.com>
>
> * mi/mi-main.c: Fix comment in mi_cmd_data_write_memory_bytes.
Small nit: The name of the function should be written between parentheses.
Like so:
* mi/mi-main.c (mi_cmd_data_write_memory_bytes): Fix comment.
I will commit this change under the obvious rule. But should you
think you'll be contributing more patches, you - or your employer
if you are making these changes as part of your work - will need
to assign your changes to the FSF. I can send you the paperwork
to get the process started, if you like. Once this is in place,
you also qualifier for Write After Approval privileges, meaning
that you can push your patches yourself once approved.
> ---
> gdb/mi/mi-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
> index 93574ca..161307a 100644
> --- a/gdb/mi/mi-main.c
> +++ b/gdb/mi/mi-main.c
> @@ -1766,7 +1766,7 @@ mi_cmd_data_write_memory_bytes (char *command, char **argv, int argc)
> else
> {
> /* Pattern is longer than or equal to count:
> - just copy len bytes. */
> + just copy count bytes. */
> data = databuf;
> }
--
Joel