Re: [PATCH] Accept convenience variable in commands -break-passcount and -break-commands

[Yao Qi <yao at codesourcery dot com>]

On 01/24/2014 08:20 PM, Yao Qi wrote:
> When I modify a MI test case to avoid hard code breakpoint number in
> the testcase, commands -break-passcount and -break-commands only
> accepts numbers and rejects convenience variables, such as $bpnum, as
> invalid input.
> 
> IWBN to teach these commands to accept convenience variables, and
> avoid hard code breakpoint number in test case.
> 
> I add a NEWS entry since it is user visible.  However, I didn't update
> the manual because manual doesn't mention that commands 'enable' 'disable'
> accept convenience variable explicitly, likewise, doesn't mention this
> for MI commands.  Some test cases are updated to replace hard code
> number with convenience variables.
> 
> Regression tested on x86_64-linux.
> 
> gdb:
> 
> 2014-01-24  Yao Qi  <yao@codesourcery.com>
> 
> 	* mi/mi-cmd-break.c (parse_number): New function.
> 	(mi_cmd_break_passcount): Use parse_number instead of atoi.
> 	(mi_cmd_break_commands): Move some code to parse_number.  Call
> 	parse_number.
> 	* NEWS: Mention that commands -break-passcount and
> 	-break-commands accept convenience variable.
> 
> gdb/testsuite:
> 
> 2014-01-24  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify):
> 	Test command -break-passcount accepts convenience variable.
> 	* gdb.trace/mi-trace-frame-collected.exp: Test command
> 	-break-commands accepts convenience variable.
> 	* gdb.trace/mi-trace-unavailable.exp: Likewise.

Ping.  https://sourceware.org/ml/gdb-patches/2014-01/msg00936.html

-- 
Yao (éå)