This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/11] Refactor ppc64 function call and return value handling
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: brobecker at adacore dot com (Joel Brobecker)
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 29 Jan 2014 19:04:26 +0100 (CET)
- Subject: Re: [PATCH 01/11] Refactor ppc64 function call and return value handling
- Authentication-results: sourceware.org; auth=none
Joel Brobecker wrote:
> I like this patch a lot. It's difficult for me to track which code
> went were, and make sure an unintended change slipped through, though,
> but I think I see logic, and everything I checked looked fine.
Thanks for your thorough review of this and the other patches, I most
definitely appreciate that.
I'll hold back with sending an updated version of the full patch set
until all outstanding questions are resolved, but I'll comment on the
specific issues you're pointing out.
> My only comment is trivial in nature, but there are many areas where
> the required empty line after the local variable declarations is
> missing.
Ah, right. I'm still not quite used to having this as a hard rule ...
I've fixed this and the other coding style issues you pointed out
(hopefully) everywhere in the patch series.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com