This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability


On 01/16/2014 07:01 PM, Doug Evans wrote:
>> >
>> > utils.c is compiled to both gdbserver and ipa.  IMO,
>> > ipa code should be thread-safe, because it can be used by a
>> > multi-threaded program.
> That would argue for removing the indentation support, at least for now.
> Fine by me.
>
> OTOH, it seemed like ipa code has its own debug printf'ing so it can
> prepend PROG, so I'm not sure this is necessary.

It's more a per-module thing, than a per-program thing.  E.g., ax.c.
Certainly PROG handling could (or perhaps should even?) be moved
to debug_printf.  (And ax_debug made a client of debug_printf).

> OTOOH, it'd be less preferable to assume(!) ipa code would never call
> debug_printf.

Yeah.

> Thoughts?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]