This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 17 Jan 2014 12:46:39 +0000
- Subject: Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability
- Authentication-results: sourceware.org; auth=none
- References: <yjt2zjnztait dot fsf at ruffy dot mtv dot corp dot google dot com> <52B1842F dot 5020401 at redhat dot com> <21205 dot 55987 dot 69477 dot 892571 at ruffy dot mtv dot corp dot google dot com> <52D826DF dot 4000505 at codesourcery dot com> <CADPb22Ts6CMhb_cEBJRDvWPFqgO7YBZaJ1PGEqj0HDVS=tKzGA at mail dot gmail dot com>
On 01/16/2014 07:01 PM, Doug Evans wrote:
>> >
>> > utils.c is compiled to both gdbserver and ipa. IMO,
>> > ipa code should be thread-safe, because it can be used by a
>> > multi-threaded program.
> That would argue for removing the indentation support, at least for now.
> Fine by me.
>
> OTOH, it seemed like ipa code has its own debug printf'ing so it can
> prepend PROG, so I'm not sure this is necessary.
It's more a per-module thing, than a per-program thing. E.g., ax.c.
Certainly PROG handling could (or perhaps should even?) be moved
to debug_printf. (And ax_debug made a client of debug_printf).
> OTOOH, it'd be less preferable to assume(!) ipa code would never call
> debug_printf.
Yeah.
> Thoughts?
--
Pedro Alves