This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 09/32] Add target_ops argument to to_close


Looks good to me.

On 01/13/2014 07:12 PM, Tom Tromey wrote:
>  static void
> -ravenscar_prepare_to_store (struct regcache *regcache)
> +ravenscar_prepare_to_store (struct target_ops *self,
> +			    struct regcache *regcache)
>  {
>    struct target_ops *beneath = find_target_beneath (&ravenscar_ops);
>  
>    if (!ravenscar_runtime_initialized ()
>        || ptid_equal (inferior_ptid, base_magic_null_ptid)
>        || ptid_equal (inferior_ptid, ravenscar_running_thread ()))
> -    beneath->to_prepare_to_store (regcache);
> +    beneath->to_prepare_to_store (beneath, regcache);
>    else
>      {
>        struct gdbarch *gdbarch = get_regcache_arch (regcache);

(At some point we should go through all find_target_beneath
users and make then follow self->beneath instead.)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]