This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Split i386_stap_parse_special_token into smaller functions


> >> FWIW, this patch looks good to me, and it is IMO a nice improvement
> >> over the current state. But i386-tdep.c is usually under Mark's
> >> responsibility, so let's give him a little bit of time to reply
> >> as well.
> >
> > Ping.
> 
> Ping^2.
> 
> This patch is pretty simple IMO (just code movement), so maybe it could
> be reviewed by some other maintainer and maybe approved?  It's holding a
> fix for a bug :-).

Go ahead and push. I reviewed the patch a second time, and it still
looks good to me.

Thank you, Sergio.
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]