This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/python+doco/NEWS] Add gdb.Type.name attribute.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Jan 2014 08:01:53 +0400
- Subject: Re: [RFA/python+doco/NEWS] Add gdb.Type.name attribute.
- Authentication-results: sourceware.org; auth=none
- References: <1387769845-28452-1-git-send-email-brobecker at adacore dot com> <87lhyp7zos dot fsf at fleche dot redhat dot com>
> Hi Joel. Today I happened to notice:
>
> Joel> +gdb_test_no_output "source ${remote_python_file}"
>
> ... this puts the full path to the .py file into the test name.
>
> I think the test should specify a name that doesn't include a path,
> instead.
>
> This same problem affects another new test,
> gdb.ada/pp-rec-component.exp.
Indeed, thanks for pointing it out. I fixed both instances with
the attached patches.
gdb/testsuite:
2014-01-10 Joel Brobecker <brobecker@adacore.com>
* gdb.ada/pp-rec-component.exp: Remove path from "source" test.
2014-01-10 Joel Brobecker <brobecker@adacore.com>
* gdb.python/py-pp-integral.exp: Remove path from "source" test.
Tested on x86_64-linux, after verifying that the gdb.sum no longer
shows the path for the "source" tests.
Pushed.
--
Joel
>From 4e23fced8108c99ddc9d52fb2c02af8cac4cc7bb Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 10 Jan 2014 07:50:29 +0400
Subject: [PATCH 1/2] Remove path from gdb.python/py-pp-integral.exp "source"
test.
gdb/testsuite/ChangeLog:
* gdb.python/py-pp-integral.exp: Remove path from "source" test.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.python/py-pp-integral.exp | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4c4dcec..283f1f2 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2014-01-10 Joel Brobecker <brobecker@adacore.com>
+
+ * gdb.python/py-pp-integral.exp: Remove path from "source" test.
+
2014-01-09 Maciej W. Rozycki <macro@codesourcery.com>
Pedro Alves <palves@redhat.com>
diff --git a/gdb/testsuite/gdb.python/py-pp-integral.exp b/gdb/testsuite/gdb.python/py-pp-integral.exp
index 1262c3f..8149bde 100644
--- a/gdb/testsuite/gdb.python/py-pp-integral.exp
+++ b/gdb/testsuite/gdb.python/py-pp-integral.exp
@@ -29,7 +29,8 @@ if ![runto tick_tock] {
set remote_python_file [gdb_remote_download host \
${srcdir}/${subdir}/${testfile}.py]
-gdb_test_no_output "source ${remote_python_file}"
+gdb_test_no_output "source ${remote_python_file}" \
+ "source ${testfile}.py"
gdb_test "print *t" " = Thu Nov 14 02:22:23 2013 \\(1384395743\\)"
--
1.8.3.2
>From a2cd8cfed14491303eb8338f90e206034c5a3fe2 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 10 Jan 2014 07:54:23 +0400
Subject: [PATCH 2/2] Remove path from gdb.ada/pp-rec-component.exp "source"
test
gdb/testsuite/ChangeLog:
* gdb.ada/pp-rec-component.exp: Remove path from "source" test.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.ada/pp-rec-component.exp | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 283f1f2..2bfeec1 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2014-01-10 Joel Brobecker <brobecker@adacore.com>
+ * gdb.ada/pp-rec-component.exp: Remove path from "source" test.
+
+2014-01-10 Joel Brobecker <brobecker@adacore.com>
+
* gdb.python/py-pp-integral.exp: Remove path from "source" test.
2014-01-09 Maciej W. Rozycki <macro@codesourcery.com>
diff --git a/gdb/testsuite/gdb.ada/pp-rec-component.exp b/gdb/testsuite/gdb.ada/pp-rec-component.exp
index faa7a0f..f2e4ab2 100644
--- a/gdb/testsuite/gdb.ada/pp-rec-component.exp
+++ b/gdb/testsuite/gdb.ada/pp-rec-component.exp
@@ -28,7 +28,8 @@ if { [skip_python_tests] } { continue }
set remote_python_file \
[gdb_remote_download host ${srcdir}/${subdir}/${gdb_test_file_name}.py]
-gdb_test_no_output "source ${remote_python_file}"
+gdb_test_no_output "source ${remote_python_file}" \
+ "source ${gdb_test_file_name}.py"
set bp_location [gdb_get_line_number "BREAK" ${testdir}/foo.adb]
runto "foo.adb:$bp_location"
--
1.8.3.2