This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove gdb_bfd_stash_filename to fix crash with fix of binutils/11983
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <hui_zhu at mentor dot com>
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>, Nick Clifton <nickc at redhat dot com>
- Date: Mon, 06 Jan 2014 09:14:00 -0700
- Subject: Re: [PATCH] Remove gdb_bfd_stash_filename to fix crash with fix of binutils/11983
- Authentication-results: sourceware.org; auth=none
- References: <52C8358B dot 7080101 at mentor dot com> <m3mwja5v01 dot fsf at redhat dot com> <52C97EC0 dot 3080807 at mentor dot com> <87k3edseia dot fsf at fleche dot redhat dot com> <52CA8A7F dot 7090907 at mentor dot com>
>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
>> solib-spu.c:spu_bfd_open
>> spu-linux-nat.c:spu_bfd_open
Hui> These two functions have used xstrdup, for example:
Oops, yeah. Thanks.
Hui> 2014-01-06 Hui Zhu <hui@codesourcery.com>
Hui> * gdb_bfd.c (gdb_bfd_stash_filename): Removed.
Hui> (gdb_bfd_open): Removed gdb_bfd_stash_filename.
Hui> (gdb_bfd_fopen): Ditto.
Hui> (gdb_bfd_openr): Ditto.
Hui> (gdb_bfd_openw): Ditto.
Hui> (gdb_bfd_openr_iovec): Ditto.
Hui> (gdb_bfd_fdopenr): Ditto.
Hui> * gdb_bfd.h (gdb_bfd_stash_filename): Removed.
Hui> * solib-aix.c (solib_aix_bfd_open): Alloc object_bfd->filename
Hui> with xstrdup.
Hui> * solib-darwin.c (darwin_bfd_open): Alloc res->filename
Hui> with xstrdup.
Hui> * symfile-mem.c (symbol_file_add_from_memory): Removed
Hui> gdb_bfd_stash_filename.
This is ok.
Tom