This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "jan dot kratochvil at redhat dot com" <jan dot kratochvil at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Eli Zaretskii <eliz at gnu dot org>
- Date: Fri, 20 Dec 2013 14:36:37 +0000
- Subject: RE: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support
- Authentication-results: sourceware.org; auth=none
- References: <1387471499-29444-1-git-send-email-markus dot t dot metzger at intel dot com> <1387471499-29444-30-git-send-email-markus dot t dot metzger at intel dot com> <52B3529E dot 70407 at redhat dot com>
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, December 19, 2013 9:10 PM
> > + if (non_stop)
> > + error (_("Record btrace can't debug inferior in non-stop mode "
> > + "(non-stop)."));
>
> What's the intent of saying non-stop twice, in:
>
> "in non-stop mode (non-stop)"
I took this from s/w record without thinking. Fixed.
> > + /* Stop all other threads. */
> > + if (!non_stop)
> > + ALL_THREADS (other)
> > + other->btrace.flags &= ~BTHR_MOVE;
>
> (I know it doesn't work currently), but in non-stop, the
> event thread should also get its BTHR_MOVE flag cleared.
> I didn't spot where that was being done.
It's done in record_btrace_step_thread right at the beginning.
> > + /* GDB seems to need this. Without, a stale PC seems to be used
> resulting in
> > + the current location to be displayed incorrectly. */
> > + registers_changed_ptid (tp->ptid);
>
> This really shouldn't be necessary, given target_resume does
> it for you. If you still needed, you're papering over some
> problem.
If we start replaying in to_wait, we'll call get_current_frame
to fix up some stepping related frames. This will be done on
the current PC.
When we step later on in record_btrace_step_thread, we change
the replay position but not the PC.
I guess it will be more clear when I move this into
record_btrace_step_thread and change the comment.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052