This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix PR 16201: internal error on a cygwin program linked against a DLL with no .data section
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 2 Dec 2013 18:10:17 +0400
- Subject: Re: [RFA] Fix PR 16201: internal error on a cygwin program linked against a DLL with no .data section
- Authentication-results: sourceware.org; auth=none
- References: <007101ceebd1$3d2bb590$b78320b0$ at muller@ics-cnrs.unistra.fr> <20131202033043 dot GP3114 at adacore dot com> <006401ceef4b$83db3510$8b919f30$ at muller@ics-cnrs.unistra.fr> <20131202113646 dot GV3114 at adacore dot com> <000001ceef67$6414ae70$2c3e0b50$ at muller@ics-cnrs.unistra.fr>
> But could you elaborate onto why you are unsure about the patch?
> What is bothering you?
Sure. I may have expressed myself poorly. The patch wasn't obvious,
and I didn't have time to look into it more closely. So if I were
the one reviewing it, I'd need a small chunk of free time to really
understand it well, and double-check its possible unwanted side-effects.
Maybe someone else, who is more familiar with objfiles et al, might
find it easier to review.
--
Joel