This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/10] vla: update type from newly created value


On Wed, Nov 20, 2013 at 2:29 AM, Pedro Alves <palves@redhat.com> wrote:
> On 10/21/2013 03:40 PM, Sanimir Agovic wrote:
>> Constructing a value based on a type and address might change the type
>> of the newly constructed value.
>
> OOC (and for the archives), why's that?  Where does that occur?
>
>> Thus re-fetch type via value_type to ensure
>> we have the correct type at hand.

Not just for the archives.

I didn't find it in the patch series, but I could have missed it of course.

I think a VERY LOUD comment needs to be added to these routines to
tell the reader "HEADS UP! If you do <this> after calling me, then you
MUST also do <this>."
[or words to that effect]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]