This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] set/show code-cache
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 21 Nov 2013 14:11:57 -0700
- Subject: Re: [PATCH 2/3] set/show code-cache
- Authentication-results: sourceware.org; auth=none
- References: <1384996594-20865-1-git-send-email-yao at codesourcery dot com> <1384996594-20865-3-git-send-email-yao at codesourcery dot com> <528D781A dot 7070909 at codesourcery dot com> <871u29h7oa dot fsf at fleche dot redhat dot com> <CADPb22QeSOxno1LNhJat=AMwA5Lp-3DvsPkpFtSAMD-W9pbymA at mail dot gmail dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Tom> It seems unusual to have "ON" in upper case.
Doug> cut-n-paste from the stack-cache case.
Doug> I forget what the rules are here.
Doug> Do we require fixing the stack-cache case first?
I don't know if we have a rule.
I generally try not to require people to fix existing problems.
My view is that patch submitters aren't responsible for the context; and
that if it matters that much to me, I can fix it myself. (On occasion I
may ask nicely though...)
But, I think it's ok to require that new bad cases not go in, as a
general rule.
Tom