This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Stan Shebs <stan at codesourcery dot com>
- Date: Thu, 7 Nov 2013 09:32:08 -0800
- Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
- Authentication-results: sourceware.org; auth=none
- References: <yjt24n85x78h dot fsf at ruffy dot mtv dot corp dot google dot com> <20131031154957 dot GA11260 at host2 dot jankratochvil dot net> <CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A at mail dot gmail dot com> <87li13shk2 dot fsf at fleche dot redhat dot com> <CADPb22QNaGzvagsDwgt2mAVOQw9kQxtKbnHKtnTbUMy-7xaJhw at mail dot gmail dot com> <20131105172219 dot GA21529 at host2 dot jankratochvil dot net> <CADPb22Tcg9g=pCG1q07hK6DkRnTQop7bZynqnoN+upiuDBWsZA at mail dot gmail dot com> <20131105180547 dot GA24004 at host2 dot jankratochvil dot net> <CADPb22S4ivEm=abcrxLBQwiB9yrB7CryvOBNi+rh-GdOpek5nQ at mail dot gmail dot com> <20131106212434 dot GA4193 at host2 dot jankratochvil dot net>
On Wed, Nov 6, 2013 at 1:24 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Wed, 06 Nov 2013 22:14:27 +0100, Doug Evans wrote:
>> It will basically say tests are in general not required to following
>> the GDB coding standards,
>
> What is the reason for it?
To codify the existing rules, as I understand them, and as has
been affirmed from time to time.
> I would find more logical to say tests should follow the same rules as GDB
> code, unless there is a specific reason for it. Such as importing an existing
> external reproducer, machine generated output etc.
>
> If GDB coding standards are not acceptable for testcases then it looks to me
> as an indication the GDB coding standards should be changed.
I don't mind such changes, but these are changes. Agreed?
I was trying to end the thread, and make some minimal mutually agreeable
progress.
Also, AIUI, this community generally frowns on cleanup projects that
will drag on.
I can mechanically run every .c file through indent with some settings
people agree on, but
I'm not signing up to audit the entire testsuite to make sure we don't
accidentally
change a test that has important reasons for why it is written the way it is.
OTOH, if we can all agree that existing tests need only be lazily
updated (or not at all -
I don't have a strong opinion) then that works too (though coding standards
work so much better when Monkey See Monkey Do hacking Just Works).