This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve MI inferior output check / mi-console.exp


On 11/05/2013 04:13 PM, Pedro Alves wrote:
On 11/04/2013 04:41 AM, Luis Machado wrote:
I don't think it does completely yet?  A check for the
sim is missing.  We'd need:

      [target_info protocol] == "sim"

(see mi_gdb_target_load)
Done.

...

-		    -i $mi_inferior_spawn_id -re "$ipattern" {
-			pass "$message inferior output"
+		if { [target_info gdb_protocol] == "remote"
+		    || [target_info gdb_protocol] == "extended-remote"
+		    || [target_info gdb_protocol] == "sim"} {

That's not what I suggested, and I don't think it'd work
the same?

Bummer. Tired eyes didn't notice the small difference between the variable names.


Otherwise looks OK.


I'll check the fixed version in.

Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]