This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
- From: Tom Tromey <tromey at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, ktietz at redhat dot com, gdb-patches at sourceware dot org
- Date: Wed, 09 Oct 2013 11:08:47 -0600
- Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
- Authentication-results: sourceware.org; auth=none
- References: <20131008183214 dot GB27355 at host2 dot jankratochvil dot net> <87li23fsym dot fsf at fleche dot redhat dot com> <20131009131016 dot GA1603 at host2 dot jankratochvil dot net> <83hacqqsx7 dot fsf at gnu dot org>
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
Eli> Please don't do that. On latest versions of Windows, the runtime
Eli> library functions tend to invoke the "invalid parameter handler" in
Eli> these cases, which more often than not will crash the program.
The status quo ante was to do the call but not check for EINVAL.
So the bug, if there is one, is already there.
Can you check?
Tom