This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/7] New lang-varobj.h


>  > 2013-09-18  Yao Qi  <yao@codesourcery.com>
>  > 
>  > 	* Makefile.in (HFILES_NO_SRCDIR): Add lang-varobj.h.
>  > 	* lang-varobj.h: New.
>  > 	* varobj.c: Include "lang-varobj.h".
>  > 	(struct varobj_root): <lang>: Update its type.
>  > 	(struct language_specific): Move it to lang-varobj.h.
> 
> Hi.
> 
> How about move lang-varobj.h into varobj.h?

Not very important in the grand scheme of things, but I tend to agree
with the suggestion. If we had a lang-varobj.c, things might be
different. But for a simple definition of the language-specific ops
directly related to varobj, I'd keep things simple, inside varobj.h.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]