This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gnu-nat.c: Don't install a deprecated_xfer_memory method.


On 09/19/2013 09:20 AM, Thomas Schwinge wrote:

> On Fri, 06 Sep 2013 19:46:15 +0100, Pedro Alves <palves@redhat.com> wrote:
>> Hi!  This removes another instance of a deprecated_xfer_memory user.
>> Could perhaps one of you guys try this out?
> 
> Doing that for you.  ;-) In fact, I had already done this on the weekend
> after you submitted the patch, then got interrupted, then failed to
> resume...  :-/

I know how that works.  :-)

> As Yue has also found,
> <http://news.gmane.org/find-root.php?message_id=%3CCAB8fV%3Di90kf3Eng9aQWb%3DJV%2BR6vPm4Bj5B3aq3X5HHzxVKbLwA%40mail.gmail.com%3E>,
> this needs a small fix to make it build.  Here is my version including
> additional clean-up (making the functions static avoids compiler warnings
> about missing prototypes, likewise the char * -> gdb_byte mirrors your
> gnu_write_inferior change and avoids warnings, too).  Will apply this
> (folded into your patch) once the GDB testsuite returns (rebased against
> current upstream sources).

Thanks!

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]