This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] New functions gdb_find_readelf, gdb_find_objcopy for testsuite
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 19 Sep 2013 16:27:55 -0700
- Subject: Re: [patch] New functions gdb_find_readelf, gdb_find_objcopy for testsuite
- Authentication-results: sourceware.org; auth=none
- References: <yjt2li2vdv2j dot fsf at ruffy dot mtv dot corp dot google dot com> <87wqmdudaq dot fsf at fleche dot redhat dot com>
On Wed, Sep 18, 2013 at 12:42 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> [transform objcopy] and [transform readelf] aren't always sufficient
> Doug> to find the right copy to use.
> Doug> Akin to most other tools that have FOO_FOR_TARGET this patch
> Doug> adds support for READELF_FOR_TARGET and OBJCOPY_FOR_TARGET.
>
> Doug> Regression tested on amd64-linux.
> Doug> I will commit this in a few days if there are no objections.
>
> Seems reasonable to me.
>
>
> Doug> +proc gdb_find_objcopy {} {
> Doug> + global OBJCOPY_FOR_TARGET
> Doug> + if [info exists OBJCOPY_FOR_TARGET] {
>
> Normally I follow the C rule here about comments and newlines after
> "declarations".
OOC, in a C++ world (or C99) world where we can put declarations
closer to their use, would be still have this rule?