This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/3] Code cleanup: OPF_DISABLE_REALPATH -> OPF_RETURN_REALPATH
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 3 Sep 2013 15:23:59 -0700
- Subject: Re: [patch 1/3] Code cleanup: OPF_DISABLE_REALPATH -> OPF_RETURN_REALPATH
- Authentication-results: sourceware.org; auth=none
- References: <20130828160537 dot GB23977 at host2 dot jankratochvil dot net>
Jan Kratochvil writes:
> Hi,
>
> in the future most (or even all) of the OPF_RETURN_REALPATH uses in callers
> should be dropped. But this patch makes no functionality change.
>
> It was proposed by Doug.
>
> The patch is IMO not absolutely correct, changing behavior of function should
> also rename the function so that 3rd party patches do not get quietly broken.
>
>
> Jan
>
>
> gdb/
> 2013-08-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup: Change OPF_DISABLE_REALPATH to OPF_RETURN_REALPATH.
> * cli/cli-cmds.c (find_and_open_script): Add OPF_RETURN_REALPATH to
> variable search_flags.
> * defs.h (OPF_DISABLE_REALPATH): Rename to ...
> (OPF_RETURN_REALPATH): ... here.
> * dwarf2read.c (try_open_dwop_file): Set OPF_RETURN_REALPATH for flags.
> * exec.c (exec_file_attach): Remove OPF_DISABLE_REALPATH from openp
> call. Twice.
> * nto-tdep.c (nto_find_and_open_solib): Add OPF_RETURN_REALPATH for
> openp call.
> * solib.c (solib_find): Likewise. Four times.
> * source.c (openp): Change OPF_DISABLE_REALPATH to OPF_RETURN_REALPATH
> in the function comment and for the realpath_fptr variable.
> (source_full_path_of): Add OPF_RETURN_REALPATH for openp call.
> (find_and_open_source): Likewise. Twice.
> * symfile.c (symfile_bfd_open): Likewise, also twice.
Thanks. "works for me"