This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Unbuffer stdout and stderr on windows
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Wed, 28 Aug 2013 10:38:55 +0100
- Subject: Re: [PATCH] Unbuffer stdout and stderr on windows
- Authentication-results: sourceware.org; auth=none
- References: <83eh9uonlg dot fsf at gnu dot org> <20130815175940 dot GD6955 at ednor dot casa dot cgf dot cx> <520E1109 dot 7000304 at redhat dot com> <520E1C34 dot 2000907 at codesourcery dot com> <520E2B13 dot 8020706 at redhat dot com> <83r4dtn35q dot fsf at gnu dot org> <520E357E dot 6080803 at redhat dot com> <83mwohn0nj dot fsf at gnu dot org> <520E40CD dot 7080604 at redhat dot com> <5215AC28 dot 3030506 at codesourcery dot com> <20130822141756 dot GB5221 at adacore dot com> <5216C6B0 dot 90906 at codesourcery dot com> <521D0E8A dot 80303 at redhat dot com> <521DA52C dot 9020003 at codesourcery dot com>
On 08/28/2013 08:22 AM, Yao Qi wrote:
> +/* Create a ui_file from stderr. */
> +
I think this should be in the header....
> +struct ui_file *
> +stderr_fileopen (void)
> +{
> @@ -129,6 +129,9 @@ extern struct ui_file *mem_fileopen (void);
> /* Open/create a STDIO based UI_FILE using the already open FILE. */
> extern struct ui_file *stdio_fileopen (FILE *file);
>
> +extern struct ui_file *stderr_fileopen (void);
> +
> +
... as the other functions (seen from context) are documented here
too.
> /* Open NAME returning an STDIO based UI_FILE. */
> extern struct ui_file *gdb_fopen (const char *name, const char *mode);
> +
> + /* Method 'to_write_async_safe' is not overwritten, because there's
> + no way to flushing a stream in an async-safe manner.
Sorry, my own fault -- should read "to flush".
This is OK with those fixes.
Thanks,
--
Pedro Alves