This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Windows x64 SEH unwinder
- From: Pedro Alves <palves at redhat dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>, Joel Brobecker <brobecker at adacore dot com>, Roland Schwingel <roland dot schwingel at onevision dot de>
- Date: Tue, 27 Aug 2013 18:45:37 +0100
- Subject: Re: [PATCH v3] Windows x64 SEH unwinder
- Authentication-results: sourceware.org; auth=none
- References: <1357728781-15073-1-git-send-email-brobecker at adacore dot com> <1357728781-15073-3-git-send-email-brobecker at adacore dot com> <50ED9221 dot 1050504 at redhat dot com> <9E84DF2D-7AF8-4AA1-A5DF-171EF189A6E7 at adacore dot com> <50EDA48E dot 2030406 at redhat dot com> <66611BA9-4536-42B2-A65C-4EA5DA219E22 at adacore dot com> <50EEEB3C dot 9050202 at redhat dot com> <5BE11EDB-7832-4489-8CB1-6382F5D1D34E at adacore dot com> <51F29440 dot 3030808 at redhat dot com> <6F12353E-D32C-40F0-87BF-AA77FC15BE03 at adacore dot com> <52162DA9 dot 5060108 at redhat dot com> <848C81AC-2171-412B-A6F2-101352933F3E at adacore dot com> <52163929 dot 1090008 at redhat dot com> <9FD66EEA-C685-4F32-8F91-F9E0FF6AAAEE at adacore dot com>
Hi there,
On 08/23/2013 07:53 AM, Tristan Gingold wrote:
>
> On Aug 22, 2013, at 6:15 PM, Pedro Alves <palves@redhat.com> wrote:
>> I'm guessing that using SEH if available would
>> be better over dwarf2 (though I don't know for sure).
>
> Why ?
No particular reason -- I guess I got confused by earlier
discussions in v1/v2, and I understood it as such.
> I think that both unwinders should be correct. One might
> be faster than the other, but I don't know which.
Okay.
>
>> And, this version is then a compromise. Right?
>
> The only compromise is when there are no unwind infos. Previously
> a default unwinder based on heuristic was used (doesn't work well,
> particularly for MS dll). With the patch, they are considered as
> leaf functions by the SEH unwinder.
Okay.
FAOD, the patch is fine with me.
--
Pedro Alves