This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v3] Added file properties to windows gdb executable for all mingw32 builds.
- From: "Bunk, Bernd" <bernd dot bunk at intel dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "tromey at redhat dot com" <tromey at redhat dot com>, "eliz at gnu dot org" <eliz at gnu dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 26 Aug 2013 12:27:08 +0000
- Subject: RE: [PATCH v3] Added file properties to windows gdb executable for all mingw32 builds.
- Authentication-results: sourceware.org; auth=none
- References: <1377273278-10370-1-git-send-email-bernd dot bunk at intel dot com> <52178748 dot 9070909 at redhat dot com>
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Friday, August 23, 2013 6:01 PM
> To: Bunk, Bernd
> Cc: tromey@redhat.com; palves@redhat.com; eliz@gnu.org; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH v3] Added file properties to windows gdb executable
> for all mingw32 builds.
>
> On 08/23/2013 04:54 PM, Bernd Bunk wrote:
> > On Windows OS it is custom that executables and DLL's show file
> properties.
> > These contain product name/version, file name/version,
> company/copyright info.
> > File properties are visible by right-click on the file, selecting
> properties \ details.
> > This patch adds file properties to the gdb executable for all mingw
> builds.
> >
> > 2013-08-14 Bernd Bunk <bernd.bunk@intel.com>
> >
> > * Makefile.in (windows_exe_properties.h): Add rule to create
> > windows_exe_properties.h header file with file property
> information.
> > (windows_exe_properties.o): Added rule to build the resource
> file.
>
> I didn't find where this was updated to write to a temporary file, and
> then move to the final destination. Did I miss something?
>
> > * configure: Add windows_exe_properties.o to mingw32 specific
> > objects.
>
> configure is a generated file. You'll need to edit configure.ac
> instead.
Oha, good catch. I never regenerated the configure file so far, so I didn't see this. I will make my change in the configure.ac file as proposed and regenerate the configure file. [see v4 coming soon]
>
> --
> Pedro Alves
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052