Re: [PATCH 2/5] [PR gdb/15224] Fix incorrectly touched history file even if no commands get, added to it

[Muhammad Bilal <mbilal at codesourcery dot com>]

On 08/13/2013 11:09 PM, Pedro Alves wrote:
> On 08/08/2013 06:18 AM, Muhammad Bilal wrote:
>
> > History save should be perform on interactive debugging.
> > so, using the  input_from_terminal_p fixed this problem.
> >
> >
> > 2013-08-08  Muhammad Bilal  <mbilal@codesourcery.com>
> >
> >       PR gdb/15224
> (Just like PR cli/15715, all these bugs should each their own
> different number, and then 15224 should be made dependent of
> them.  This patch is not about saving history by default, although
> it is a necessary dependency for doing that.)
>
> >       * top.c (quit_force): Fixed incorrectly touching history file
> >       to use input_from_terminal_p.
> "Fixed incorrectly" is a "why" and ambiguous (and sometimes, wrong).
>
> Say:
>
>       * top.c (quit_force): Skip writing history file
>       if input is not from terminal.
>
> Otherwise OK.
>
> Thanks,
Committed with new PR http://sourceware.org/bugzilla/show_bug.cgi?id=15841


Thanks,
-Bilal