This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] Avoid unlimited height on mingw built GDB's.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Eli Zaretskii'" <eliz at gnu dot org>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 13 Aug 2013 10:40:36 +0200
- Subject: RE: [RFA] Avoid unlimited height on mingw built GDB's.
- References: <"001c01ce9412$2c438df0$84caa9d0$ at muller"@ics-cnrs.unistra.fr> <83eha3rmm4 dot fsf at gnu dot org>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Eli Zaretskii
> Envoyé : vendredi 9 août 2013 16:00
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] Avoid unlimited height on mingw built GDB's.
>
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Date: Thu, 8 Aug 2013 10:35:01 +0200
> >
> > Mingw builds are using windows-termcap.c source
> > to allow compilation despite the fact that there
> > is often no termcap library for mingw.
> > The stub tgetnum function returns -1 unconditionally,
> > this leads to the screen height being set to unlimited
> > in init_page_info function.
> >
> > Before this, lines_per_page was set correctly
> > by the call to rl_get_screen_size.
> >
> > The patch simply avoid checking tgetnum ("li") if
> > the rows parameter was set to a positive value.
>
> Looks good to me, thanks.
Thank you for the approval,
patch committed,
Pierre Muller