This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/7] AVR support
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 07 Aug 2013 18:03:08 -0300
- Subject: Re: [PATCH 4/7] AVR support
- References: <1374869594-16965-1-git-send-email-sergiodj at redhat dot com> <1374869594-16965-5-git-send-email-sergiodj at redhat dot com> <CADPb22Q9-AaJ=WFK4qXaQdzEFQ3_EHfngLJaWZ8C9Cue=yptyA at mail dot gmail dot com>
On Saturday, July 27 2013, Doug Evans wrote:
> Hi. Just a nit.
>
> On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
>> Support for the AVR architecture. More of the same. Defining an enum
>> containing the differences between Linux kernel generic and AVR signals,
>> and treat them on avr_linux_gdb_signal_{to,from}_target. In this case,
>> the only difference is the SIGRTMAX.
>>
>> 2013-07-26 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * avr-tdep.c: Define enum with differences between Linux kernel
>> and AVR signals.
>> (avr_linux_gdb_signal_from_target): New function.
>> (avr_linux_gdb_signal_to_target): Likewise.
>> (avr_gdbarch_init): Set gdbarch_gdb_signal_{to,from}_target to
>> the functions mentioned above.
>> [...]
>> + /* GDB_SIGNAL_REALTIME_33 to _63 are continuous.
>> +
>
> Nit: Either delete this blank line or move it to after the comment.
Fixed, thanks.
--
Sergio